[OpenAFS-devel] Re: [PATCH] crget() memory allocation oddity

Joe Buehler jbuehler@spirentcom.com
Fri, 09 Jun 2006 09:42:15 -0400


> --- src/afs/LINUX/osi_cred.c.~1~	2005-04-03 15:49:21.000000000 -0400
> +++ src/afs/LINUX/osi_cred.c	2006-06-02 10:04:45.000000000 -0400
> @@ -21,7 +21,7 @@
>  #include "afsincludes.h"
> 
>  /* Setup a pool for creds. Allocate several at a time. */
> -#define CRED_ALLOC_STEP 29	/* at 140 bytes/cred = 4060 bytes. */
> +#define CRED_ALLOC_STEP (PAGE_SIZE / sizeof(cred_t)) /* allocate <= 1 page at a time */
> 
> 
>  static cred_t *cred_pool = NULL;

There have been no server crashes for several days after applying the above
patch.  I will submit it to the bug tracker if the machines survive
the weekend full backups.
-- 
Joe Buehler