[OpenAFS-devel] Fwd: [patch review] libafs solaris cleanup

[Matt Benjamin]

Dale,

You may have hit a 1980s landmine, I don't know.  I've just been using 
bad style all these years ;)

Matt

Dale Ghent wrote:
> On Feb 12, 2007, at 12:14 PM, Jim Rees wrote:
>
>> Matt Benjamin wrote:
>>
>>   Respectfully, I haven't seen this stylistic preference in Unix source
>>   code or style guidelines (eg, Rob Pike).
>>
>> style(9) calls for using parens.  But most of the existing afs code 
>> leaves
>> out the parens, and I think it's best to be consistent with what we 
>> have.
>
> Heh, well I have to chuckle at this. If you look at the files I 
> touched, there was already pretty much a 50/50 mix when it comes to 
> using parens or not *in the same file*. I was just trying to instill 
> some concept of consistency in their use... too bad I seemed to have 
> stepped on some sort of landmine in doing so.
>
>> And as Jeffrey notes, it's best not to put in a bunch of style 
>> changes in a
>> patch.
>
> Fine, alright. I'll remove them and resubmit the patch when I have time.
>
> /dale
>
> -- 
> Dale Ghent
> UNIX Systems Specialist
> UMBC - Office of Information Technology
> ECS 201 - x51705
>
>
>


-- 

Matt Benjamin

The Linux Box
206 South Fifth Ave. Suite 150
Ann Arbor, MI  48104

http://linuxbox.com

tel. 734-761-4689
fax. 734-769-8938
cel. 734-216-5309