[OpenAFS-devel] Fwd: [patch review] libafs solaris cleanup

[Dale Ghent]

On Feb 12, 2007, at 12:14 PM, Jim Rees wrote:

> Matt Benjamin wrote:
>
>   Respectfully, I haven't seen this stylistic preference in Unix  
> source
>   code or style guidelines (eg, Rob Pike).
>
> style(9) calls for using parens.  But most of the existing afs code  
> leaves
> out the parens, and I think it's best to be consistent with what we  
> have.

Heh, well I have to chuckle at this. If you look at the files I  
touched, there was already pretty much a 50/50 mix when it comes to  
using parens or not *in the same file*. I was just trying to instill  
some concept of consistency in their use... too bad I seemed to have  
stepped on some sort of landmine in doing so.

> And as Jeffrey notes, it's best not to put in a bunch of style  
> changes in a
> patch.

Fine, alright. I'll remove them and resubmit the patch when I have time.

/dale

--
Dale Ghent
UNIX Systems Specialist
UMBC - Office of Information Technology
ECS 201 - x51705