[OpenAFS-devel] Uncontrolled full salvage

Rainer Toebbicke rtb@pclella.cern.ch
Fri, 11 May 2007 11:33:40 +0200


This is a multi-part message in MIME format.
--------------040803080608000602050200
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

The salvager does uncontrolled forced salvages since ListViceInodes 
forgets to clear the "forcep" parameter.

Trivial patch attached, bcc'ed to openafs-bugs.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Rainer Toebbicke
European Laboratory for Particle Physics(CERN) - Geneva, Switzerland
Phone: +41 22 767 8985       Fax: +41 22 767 7155

--------------040803080608000602050200
Content-Type: text/plain;
 name="p_random_salvage"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="p_random_salvage"

--- openafs/src/vol/namei_ops.c.o144	2007-03-20 14:36:37.000000000 +0100
+++ openafs/src/vol/namei_ops.c	2007-05-11 11:21:59.000000000 +0200
@@ -1146,6 +1146,8 @@
     int ninodes;
     struct afs_stat status;
 
+    *forcep = 0;		/* no need to salvage until further notice */
+
     if (resultFile) {
 	fp = afs_fopen(resultFile, "w");
 	if (!fp) {

--------------040803080608000602050200--