[OpenAFS-devel] vol/partition.c#1.34

[Frank Cusack]

On May 10, 2007 3:28:27 PM -0700 Frank Cusack <fcusack@fcusack.com> wrote:
> I think r1.34 was changed to attach zfs volumes automatically:
>
> if (((!strcmp(mnt.mnt_fstype, "ufs") && !strcmp(mnt.mnt_fstype, "zfs")))
>
> This is always false.  The source of this patch (rt #56531) is bogus so
> I guess that ticket should be updated.
>
> I assume it should be
>
> if ((!(strcmp(mnt.mnt_fstype, "ufs") && strcmp(mnt.mnt_fstype, "zfs")))

oops .. also wrong.  Try this:

        /* Ignore non ufs or non read/write partitions */
        /* but allow zfs too if we're in the NAMEI environment */
        if (
#ifdef AFS_NAMEI_ENV
        (strcmp(mnt.mnt_fstype, "ufs") && strcmp(mnt.mnt_fstype, "zfs"))
#else
        (strcmp(mnt.mnt_fstype, "ufs") != 0)
#endif
        || (strncmp(mnt.mnt_mntopts, "ro,ignore", 9) == 0))
            continue;

-frank