[OpenAFS-devel] checking for do_sync_read() linux-2.6.24.2 openafs-1.4.6

[Marc Dionne]

------=_Part_11561_20839186.1203425694288
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Feb 19, 2008 5:56 AM, Jirka Matela <xmatela@fi.muni.cz> wrote:

> Hi,
>
> I can't get compiled 1.4.6 against linux-2.6.24.2. It always crashes when
> it
> gets to:
>
> src/libafs/MODLOAD-2.6.24.2-SP/osi_vnodeops.c: In function
> 'afs_linux_read':
> src/libafs/MODLOAD-2.6.24.2-SP/osi_vnodeops.c:81:
> error: implicit declaration of function 'generic_file_read'
>
> Really, there is no such function in 2.6.24.2. The do_sync_read should be
> used
> instead but it is not, since the configure script says:
>
> checking for linux do_sync_read()... no
>
> The checking routine in configure script fails because of wrong use of
> CFLAGS, see:
>
>
> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.24.y.git;a=commit;h=0c53c8e6eb456cde30f2305421c605713856abc8
>
> It should use EXTRA_CFLAGS instead of CFLAGS. With disabled checking for
> CFLAGS misuse (commented out in scripts/Makefile.build) is checking for
> do_sync_read()
> positive and afs gets compiled.
>
> Jirka
>

Hi,

This is already fixed in the current source (post 1.4.6) as part of the
fixes for 2.6.24.  There's a new configure test to check if CFLAGS can be
used, and if not, all subsequent kbuild tests use EXTRA_CFLAGS instead.

Marc

------=_Part_11561_20839186.1203425694288
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Feb 19, 2008 5:56 AM, Jirka Matela &lt;<a href="mailto:xmatela@fi.muni.cz">xmatela@fi.muni.cz</a>&gt; wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br><br>I can&#39;t get compiled 1.4.6 against linux-2.6.24.2. It always crashes when it<br>gets to:<br><br>src/libafs/MODLOAD-2.6.24.2-SP/osi_vnodeops.c: In function &#39;afs_linux_read&#39;:<br>src/libafs/MODLOAD-2.6.24.2-SP/osi_vnodeops.c:81:<br>
error: implicit declaration of function &#39;generic_file_read&#39;<br><br>Really, there is no such function in <a href="http://2.6.24.2" target="_blank">2.6.24.2</a>. The do_sync_read should be used<br>instead but it is not, since the configure script says:<br>
<br>checking for linux do_sync_read()... no<br><br>The checking routine in configure script fails because of wrong use of<br>CFLAGS, see:<br><br><a href="http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.24.y.git;a=commit;h=0c53c8e6eb456cde30f2305421c605713856abc8" target="_blank">http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.24.y.git;a=commit;h=0c53c8e6eb456cde30f2305421c605713856abc8</a><br>
<br>It should use EXTRA_CFLAGS instead of CFLAGS. With disabled checking for<br>CFLAGS misuse (commented out in scripts/Makefile.build) is checking for do_sync_read()<br>positive and afs gets compiled.<br><br>Jirka<br></blockquote>
</div><br>Hi,<br><br>This is already fixed in the current source (post 1.4.6) as part of the fixes for 2.6.24.&nbsp; There&#39;s a new configure test to check if CFLAGS can be used, and if not, all subsequent kbuild tests use EXTRA_CFLAGS instead.<br>
<br>Marc<br>

------=_Part_11561_20839186.1203425694288--