[OpenAFS-devel] 1.4.5 pre5 klog v5

[Marcus Watts]

> Date:    Wed, 02 Jan 2008 16:33:21 EST
> To:      openafs-devel@openafs.org
> From:    "Derrick Brashear" <shadow@gmail.com>
> Subject: Re: [OpenAFS-devel] 1.4.5 pre5 klog v5
> 
> On Jan 2, 2008 4:31 PM, Marcus Watts <mdw@spam.ifs.umich.edu> wrote:
> 
> > > Date:    Wed, 02 Jan 2008 16:20:40 EST
> > > To:      openafs-devel@openafs.org
> > > From:    "Derrick Brashear" <shadow@gmail.com>
> > > Subject: Re: [OpenAFS-devel] 1.4.5 pre5 klog v5
> > >
> > > it's in src/aklog; i did some work with Simon a few weeks ago to get
> > > something more sane. I suspect Makefile work to install it is needed.
> >
> > That's where the source should live.
> >
> > It probably needs both makefile & configure fixes.  The makefile work
> > needs to install klog.  kauth needs to install klog as klog.ka (and
> > *really* should install kpasswd as kpasswd.ka.)
> 
> 
> If so, we should install this as klog.krb5, and make people (or packages)
> link them instead of there being a silent behavior change, or, don't change
> it in 1.4.x.
> 
> There should also
> > be configure logic - if absolutely no k5 support, then can't build k5
> > klog, must only build and install ka klog, which may as well be installed
> > as
> > plain klog.
> 
> 
> Well, the configure logic already detects krb5 or not. Just the makefile
> needs to decide what's the right thing, really.
> 
> 
> > It may be useful to also have configure do:
> > --enable-ka-server / --disable-ka-clients
> > although those aren't strictly necessary to k5 klog.
> >

The file:
/afs/umich.edu/group/itd/build/mdw/openafs/patches/openafs-1.4.6-klog1.diff
contains diffs which should apply to stock 1.4.6 code, to result
in building klog.ka whenver aklog would also be built.

I called it 'klog.k5'.  That's easy enough to change if you hate it.

The configure/Makefile logic here is scaled way back.  I presume something
knows when to build and install aklog (not sure what -- ?) - so this
just piggy-backs on that.  If there's no such logic then I can put something
in here.

klog.c here is what was in the "1.4" branch, which has various changes
from omalleys, shadow, sxw in it.  I also added in a bunch of changes
from the rxk5 branch.  Some of those are important (freeing invalid memory
pointer) some are cosmetic (avoid extra newlines), and some just won't
matter right now (rxk5).

The library order in the makefile was wrong for klog, so I fixed that as well.

My local build instructions (aka "packaging") now move {klog,kpasswd}
to *.ka, then move klog.k5 to klog.

This built against mit 1.4.3 and mit 1.5, and the 1.4.3 version works on one
machine.

				-Marcus Watts