[OpenAFS-devel] 1.4.5 pre5 klog v5

Derrick Brashear shadow@gmail.com
Thu, 3 Jan 2008 09:29:30 -0500


------=_Part_7410_9801664.1199370570295
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

>
> The file:
> /afs/umich.edu/group/itd/build/mdw/openafs/patches/openafs-
> 1.4.6-klog1.diff
> contains diffs which should apply to stock 1.4.6 code, to result
> in building klog.ka whenver aklog would also be built.
>
> I called it 'klog.k5'.  That's easy enough to change if you hate it.
>

Given that we called the old thing "klog.krb", "klog.krb5" might be a better
parallel.

>
> The configure/Makefile logic here is scaled way back.  I presume something
> knows when to build and install aklog (not sure what -- ?) - so this
> just piggy-backs on that.  If there's no such logic then I can put
> something
> in here.
>

look at Makefile.in at the top level; if we have krb5, we build the aklog
target.

>
> klog.c here is what was in the "1.4" branch, which has various changes
> from omalleys, shadow, sxw in it.  I also added in a bunch of changes
> from the rxk5 branch.  Some of those are important (freeing invalid memory
> pointer) some are cosmetic (avoid extra newlines), and some just won't
> matter right now (rxk5).
>
> The library order in the makefile was wrong for klog, so I fixed that as
> well.
>

(It did work on the systems I tested on)

------=_Part_7410_9801664.1199370570295
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div class="Wj3C7c"><br></div></div>The file:<br>/afs/umich.edu/group/itd/build/mdw/openafs/patches/openafs-
1.4.6-klog1.diff<br>contains diffs which should apply to stock 1.4.6 code, to result<br>in building klog.ka whenver aklog would also be built.<br><br>I called it &#39;klog.k5&#39;. &nbsp;That&#39;s easy enough to change if you hate it.
<br></blockquote><div><br>Given that we called the old thing &quot;klog.krb&quot;, &quot;klog.krb5&quot; might be a better parallel.<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>The configure/Makefile logic here is scaled way back. &nbsp;I presume something<br>knows when to build and install aklog (not sure what -- ?) - so this<br>just piggy-backs on that. &nbsp;If there&#39;s no such logic then I can put something
<br>in here.<br></blockquote><div><br>look at <a href="http://Makefile.in">Makefile.in</a> at the top level; if we have krb5, we build the aklog target. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>klog.c here is what was in the &quot;1.4&quot; branch, which has various changes<br>from omalleys, shadow, sxw in it. &nbsp;I also added in a bunch of changes<br>from the rxk5 branch. &nbsp;Some of those are important (freeing invalid memory
<br>pointer) some are cosmetic (avoid extra newlines), and some just won&#39;t<br>matter right now (rxk5).<br><br>The library order in the makefile was wrong for klog, so I fixed that as well.<br></blockquote><div><br>(It did work on the systems I tested on) 
<br></div><br></div><br>

------=_Part_7410_9801664.1199370570295--