[OpenAFS-devel] Re: [OpenAFS] Syntax error in afs_md5.h on FreeBSD

Matt Benjamin matt@linuxbox.com
Sun, 13 Jan 2008 17:15:10 -0500


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

The cause of the error is probably the '-ansi' option being
added to the compile command line (MakefileProto.FBSD*).  (Makes gcc
reject the inline keyword, among other things.)

I've sent a patch to RT, against 1.4.6--openafs builds to completion on
FreeBSD 7.0 (probably will on 6.2, and has a better chance of working,
but I'm not that far along yet).

Matt

Russ Allbery wrote:
|
| "static inline" used to be a GNU extension, I believe, but it appears that
| C99 now defines it with the same semantics as GCC.  I'm not sure why
| you're getting a syntax error, but given the semantics of static inline, I
| think the safe fix is to remove the "inline", not the "static".  That will
| give you the same semantics without the inlining, and should therefore
| work the same, just a bit slower.
|
| Of course, in this particular code, it may not matter -- I haven't looked
| at it.
|


- --

Matt Benjamin

The Linux Box
206 South Fifth Ave. Suite 150
Ann Arbor, MI  48104

http://linuxbox.com

tel. 734-761-4689
fax. 734-769-8938
cel. 734-216-5309



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHio1uJiSUUSaRdSURCGDuAJ9WDdjz59rfc5X/H0vMxaX5T6otvgCZAebW
NpWqSn0k48A2s8FhZ5NVOFA=
=39Kg
-----END PGP SIGNATURE-----