[OpenAFS-devel] Solaris fixes for 1.4.x / AFS_SUN510_ENV

Derrick Brashear shadow@gmail.com
Thu, 31 Jan 2008 09:56:16 -0500


------=_Part_17938_19178510.1201791376856
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Jan 31, 2008 3:10 AM, Mike Battersby <mib@unimelb.edu.au> wrote:

> Derrick Brashear wrote:
>  > which thread?
>
> The process forked at afsd.c:2001.
>
> >     code = fork();
> >     if (code == 0) {
> >         /* Child */
> >         SET_RX_RTPRI();         /* max advised for non-interrupts */
> >         call_syscall(AFSOP_RXLISTENER_DAEMON, preallocs,
> enable_peer_stats,
> >                      enable_process_stats);
> >         exit(1);
> >     }
>
> The afs_osi_Invisible call sets SSYS on this forked child which exits.
> Bad idea.
>

All the forked children exit, eventually, but...

>
>  > where are we calling thread_create at all?
>
> Where did I say you were?
>

Actually, we are in rxk_Listener... (rx_kcommon.c) which is why this is
exiting immediately. That's the piece of information I wanted.

In any case, the patch will deal with this.

------=_Part_17938_19178510.1201791376856
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

<br><br><div class="gmail_quote">On Jan 31, 2008 3:10 AM, Mike Battersby &lt;<a href="mailto:mib@unimelb.edu.au">mib@unimelb.edu.au</a>&gt; wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Derrick Brashear wrote:<br>&nbsp;&gt; which thread?<br><br>The process forked at afsd.c:2001.<br><br>&gt; &nbsp; &nbsp; code = fork();<br>&gt; &nbsp; &nbsp; if (code == 0) {<br>&gt; &nbsp; &nbsp; &nbsp; &nbsp; /* Child */<br>&gt; &nbsp; &nbsp; &nbsp; &nbsp; SET_RX_RTPRI(); &nbsp; &nbsp; &nbsp; &nbsp; /* max advised for non-interrupts */<br>
&gt; &nbsp; &nbsp; &nbsp; &nbsp; call_syscall(AFSOP_RXLISTENER_DAEMON, preallocs, enable_peer_stats,<br>&gt; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;enable_process_stats);<br>&gt; &nbsp; &nbsp; &nbsp; &nbsp; exit(1);<br>&gt; &nbsp; &nbsp; }<br><br>The afs_osi_Invisible call sets SSYS on this forked child which exits.<br>
Bad idea.<br><div class="Ih2E3d"></div></blockquote><div><br>All the forked children exit, eventually, but... <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d"><br>&nbsp;&gt; where are we calling thread_create at all?<br><br></div>Where did I say you were?<br><div></div></blockquote><div><br>Actually, we are in rxk_Listener... (rx_kcommon.c) which is why this is exiting immediately. That&#39;s the piece of information I wanted.<br>
<br>In any case, the patch will deal with this.<br>&nbsp;<br></div></div><br>

------=_Part_17938_19178510.1201791376856--