[OpenAFS-devel] compiling a kernel module for 2.6.28.1

Chaskiel Grundman cg2v@andrew.cmu.edu
Mon, 26 Jan 2009 01:53:58 -0500 (EST)


>  CC [M]  /tmp/openafs-1.4.8/src/libafs/MODLOAD-2.6.28.1-MP/osi_vm.o
> /tmp/openafs-1.4.8/src/libafs/MODLOAD-2.6.28.1-MP/osi_vm.c: In function 'osi_VM_TryToSmush':
> /tmp/openafs-1.4.8/src/libafs/MODLOAD-2.6.28.1-MP/osi_vm.c:79: warning: 
'invalidate_inode_pages' is deprecated (declared at include/linux/fs.h:1796)
The fix for this looks like it should be to change invalidate_inode_pages 
to invalidate_remote_inode for all AFS_LINUX26_ENV. This calls 
invalidate_inode_pages for versions where that's the right thing and 
invalidate_mapping_pages where that is appropriate. (We don't support 
inodes types other than REG, LNK or DIR anyway)

>  CC [M]  /tmp/openafs-1.4.8/src/libafs/MODLOAD-2.6.28.1-MP/osi_vnodeops.o
  > /tmp/openafs-1.4.8/src/libafs/MODLOAD-2.6.28.1-MP/osi_vnodeops.c: In 
function 'afs_linux_write_begin':
  > /tmp/openafs-1.4.8/src/libafs/MODLOAD-2.6.28.1-MP/osi_vnodeops.c:1794: 
error: implicit declaration of function '__grab_cache_page'

Why not grab_cache_page? even in 2.6.28, they look identical (That is 
find_or_create_page and __grab_cache_page do exactly the same thing, other 
than a cosmetic difference in how they pass th gfp_mask through to 
alloc_pages and some code layout optimization. Probably why 
__grab_cache_page was removed....) It looks like this one has already been 
fixed in cvs, but in a different way.