[OpenAFS-devel] compiling a kernel module for 2.6.28.1

Marc Dionne marc.c.dionne@gmail.com
Mon, 26 Jan 2009 10:52:32 -0500


On Mon, Jan 26, 2009 at 1:53 AM, Chaskiel Grundman <cg2v@andrew.cmu.edu> wrote:
> Why not grab_cache_page? even in 2.6.28, they look identical (That is
> find_or_create_page and __grab_cache_page do exactly the same thing, other
> than a cosmetic difference in how they pass th gfp_mask through to
> alloc_pages and some code layout optimization. Probably why
> __grab_cache_page was removed....) It looks like this one has already been
> fixed in cvs, but in a different way.

My understanding is that the need for grab_cache_page_write_begin vs
the regular grab_cache_page is to make sure the page gets allocated
without the __GFP_FS flag set, to prevent the allocation code path
from potentially recursing back into filesystem code.

Marc