[OpenAFS-devel] openafs warnings

Marcus Watts mdw@umich.edu
Mon, 06 Jul 2009 13:19:05 -0400


At the last workshop, Simon identified "reducing warnings" as a desirable
goal of new patches for openafs.  This is an interesting problem for
large patches, because the # of warnings in openafs is large enough that
it's very difficult to sort out were inherited, and which ones are new.

Also, it looks bad when the mainline code is not up to the standard
expected of new code.

Without any more ado, here are some interesting statistics:

			grep -c 	unique source
			warning:	warning count
openafs 1.5.60(*)	2900		1955
hk28			5101		3053
hk32			419		216

stock openafs 1.5.60 needs 2 patches to build in my env.
hk28 and hk32 are "rxk5 against cvs head".
Some warnings occur more than once as various source files
are built different ways.

I expect at some point soonish to have a somewhat simplier
patch that just does this warnings cleanup.

				-Marcus Watts