[OpenAFS-devel] warnings fix

Simon Wilkinson sxw@inf.ed.ac.uk
Wed, 15 Jul 2009 09:34:45 +0100


On 15 Jul 2009, at 08:58, Felix Frank wrote:
>
> That approach contradicts the principle of least surprise, though.  
> Still, any choice will cause pain because different contributors  
> prefer different editor settings. The one advantage of expanded tabs  
> i can see atm is that gerrit *will* make it very obvious if and when  
> someone submits lines containin TAB characters. Right?

Well, you'll see a little red right arrow, but it's by no means  
obvious. What gerrit does make obvious is lines which contain  
whitespace inside tab stops, and lines with trailing whitespace. We  
should probably decide whether these are grounds for rejecting a patch  
or not.

S.