[OpenAFS-devel] gerrit: "but someone else must approve"

Jeffrey Altman jaltman@secure-endpoints.com
Sun, 26 Jul 2009 21:56:48 -0400


Simon Wilkinson wrote:
> To summarise, they are:
> 
> Code review:
> +2: Looks good to me, approved
> +1: Looks good to me, but someone else must approve
> 0: No score
> -1: I would prefer that you didn't submit this
> -2: Do not submit

Several people have felt uncomfortable with the language of +1.
How about just changing it to "Looks good to me".

Jeffrey Altman