[OpenAFS-devel] gerrit: "but someone else must approve"

Jeffrey Hutzelman jhutz@cmu.edu
Sun, 26 Jul 2009 22:43:17 -0400


--On Sunday, July 26, 2009 10:37:02 PM -0400 "Matt W. Benjamin" 
<matt@linuxbox.com> wrote:

> I agree--it is entirely legitimate for gerrit to say (and useless for it
> not to say), I object to the idea behind this change--if that is what the
> reviewer is actually saying.

Oh, I think it can only say one thing for a -1.  If you're going to object 
to integrating a change, you need to explain why.  That could be anything 
from "get rid of the warnings first" all the way up to "I don't like the 
idea at all".