[OpenAFS-devel] gerrit: "but someone else must approve"

[Matt W. Benjamin]

I agree--it is entirely legitimate for gerrit to say (and useless for it not to say), I object to the idea behind this change--if that is what the reviewer is actually saying.

Matt

----- "Jeffrey Hutzelman" <jhutz@cmu.edu> wrote:


> However, note that it is perfectly valid to give a -1 to a change that
> 
> implements a feature you don't approve of and which was never
> discussed on 
> this mailing list.  IMHO, it's reasonable to submit patches directly
> to 
> gerrit that fix genuine bugs or eliminate warnings or make the code
> more 
> closely comply with OpenAFS's coding style, but new features should be
> 
> discussed here first.
> 
> -- Jeff

-- 

Matt Benjamin

The Linux Box
206 South Fifth Ave. Suite 150
Ann Arbor, MI  48104

http://linuxbox.com

tel. 734-761-4689
fax. 734-769-8938
cel. 734-216-5309