[OpenAFS-devel] solaris krb5

[Douglas E. Engert]

This is a multi-part message in MIME format.
--------------050502030703000907080507
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Looks like src/aklog/klog.c has uninitialized variable "tofree" introduced
with AFS_RXK5.   klog.c:727 tries to free it.

This might affect other systems as well, not just Solaris.

See patch against 1.4.10


Douglas E. Engert wrote:
> 
> 
> Derrick Brashear wrote:
>> On Wed, Jun 3, 2009 at 3:34 PM, Sean O'Malley <omalleys@msu.edu> wrote:
>>> I assume this is a known issue. but is this fixed 1.5 series?
>>>
>>> I tried compiling 1.4.10 on solaris 10/sparc with the krb5 flags built
>>> against the solaris krb5 (not MIT or heimdal), with the sun compiler.
>>>
>>> It seemed to compile ok, but i tried klog and it core dumped after it
>>> authenticated.
>>
>> klog, or klog.krb5? klog has nothing to do with krb5.
> 
> Both the 1.4.8 and 1.4.10 klog.krb5 get a segfault after authenticating.
> Looking at it now.
> 
> klog to a kaserver works.
> 
> 
>>
>> not known, no.
>> _______________________________________________
>> OpenAFS-devel mailing list
>> OpenAFS-devel@openafs.org
>> https://lists.openafs.org/mailman/listinfo/openafs-devel
>>
>>
> 

-- 

  Douglas E. Engert  <DEEngert@anl.gov>
  Argonne National Laboratory
  9700 South Cass Avenue
  Argonne, Illinois  60439
  (630) 252-5444

--------------050502030703000907080507
Content-Type: text/plain;
 name="klog.tofree.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="klog.tofree.txt"

--- ,klog.c	Wed Jun  3 15:44:06 2009
+++ klog.c	Wed Jun  3 15:44:57 2009
@@ -356,7 +356,7 @@
     krb5_creds incred[1], mcred[1], *outcred = 0, *afscred;
     krb5_ccache cc = 0;
     krb5_get_init_creds_opt gic_opts[1];
-    char *tofree, *outname;
+    char *tofree = NULL, *outname;
     int code;
     char *what;
     int i, dosetpag, evil, noprdb, id;

--------------050502030703000907080507--