[OpenAFS-devel] Re: JUAFS Makefile missing key defines?

Derrick Brashear shadow@gmail.com
Wed, 10 Feb 2010 17:41:11 -0500


On Wed, Feb 10, 2010 at 5:38 PM, Chaz Chandler <clc31@inbox.com> wrote:
>
>> AFS_SGI_ENV is not 'supposed' to be defined for UAFS/JUAFS compiles.
>> Instead we define the AFS_USR_SGI_ENV symbol. (also, this is defined in
>> afs/param.h, not on the command line)
>>
>> If you find this a bit confusing, so do I. But I'm not sure it's worth
>> the effort changing when you consider how many AFS_*_ENV tests there are
>> everywhere that would need to be checked...
>
> Heh, yes, I see now.
>
>
>> Do you need the AFS_SGI_ENV part of the struct-label test? (!__c99 by
>> itself won't work?).
>
> I guess it's possible, but then it does make the code less readable (one
> might not know, for instance, that __c99 is only defined by MIPSPro C in
> -c99 mode).
>
>
>> Or it might be
>> due to nobody trying to compile IRIX on 1.5 in a long time.
>
> I think it might be the latter of these two. :)
>
>
>> Try without AFS_SGI_ENV first.
>
> Yes, that's the default (and the first error message from before).
>
>
> So we could either compile JUAFS with c99, remove JUAFS from the default
> compile on IRIX, or find some (possibly ugly) AFS_*_ENV solution. =A0Thou=
ghts?

Given that another option was already suggested, I'll offer "none of the ab=
ove"


--=20
Derrick