[OpenAFS-devel] Re: OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_74_1-264-g9316f20

[Benjamin Kaduk]

On Mon, 14 Jun 2010, Gerrit Code Review wrote:

> The following commit has been merged in the master branch:
> commit 9316f209eda47362d7b96464b1fff4bd5b086da7
> Author: Jeffrey Altman <jaltman@your-file-system.com>
> Date:   Mon Jun 14 14:13:11 2010 -0400
>
>    Windows: ensure that afsconfig.h and afs/param.h are included
>
>    The recent addition of AFS_NORETURN broke the Windows build
>    because afsconfig.h and afs/param.h were not included everywhere.
>    Make sure that they are.

This breaks the build on FBSD, at least:
make finale 
DEST=/usr/ports/net/openafs-devel/work/openafs/amd64_fbsd_90/dest CO
MPILE_PART2B=all DESTDIR=
mkdir -p /usr/ports/net/openafs-devel/work/openafs/include/afs
mkdir -p /usr/ports/net/openafs-devel/work/openafs/include/rx
mkdir -p /usr/ports/net/openafs-devel/work/openafs/include/des
mkdir -p /usr/ports/net/openafs-devel/work/openafs/lib
cd src && cd config && make all
rm -f Makefile.version
if      [ -r /usr/ports/net/openafs-devel/work/openafs/src/CML/state ] ; 
then
cp Makefile.version-CML Makefile.version ;  else        cp 
Makefile.version-NOCM
L Makefile.version ;  fi
make -f Makefile.version AFS_component_version_number.c
echo 'char cml_version_number[]="@(#) OpenAFS 1.5.74.1 built ' `date 
+"%Y-%m-%d"
` '";' >AFS_component_version_number.c
echo 'char* AFSVersion = "openafs 1.5.74.1"; ' 
>>AFS_component_version_number.c
cc -g -O -I/usr/ports/net/openafs-devel/work/openafs/include -O2 -pipe 
-fPIC  -I
. -c ./config.c
cc -g -O -I/usr/ports/net/openafs-devel/work/openafs/include -O2 -pipe 
-fPIC  -I
. -c ./mc.c
cc -g -O -I/usr/ports/net/openafs-devel/work/openafs/include -O2 -pipe 
-fPIC  -o
  config config.o mc.o
cc -g -O -I/usr/ports/net/openafs-devel/work/openafs/include -O2 -pipe 
-fPIC  -o
  mkvers ./mkvers.c
./mkvers.c:15:23: error: afsconfig.h: No such file or directory
./mkvers.c:16:23: error: afs/param.h: No such file or directory
*** Error code 1

Reverting it (and applying gerrit/2160) allows the build to complete.

-Ben