[OpenAFS-devel] Re: adding "make check" to build slaves

[Jeffrey Altman]

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig99729CAFB31DF0EF7D636EC8
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 4/10/2012 1:26 PM, Garrett Wollman wrote:
> <<On Tue, 10 Apr 2012 08:17:14 -0400, Jeffrey Altman <jaltman@secure-en=
dpoints.com> said:
>=20
>> Its quite simple really.  You ask each of the builder owners to run ma=
ke
>> check on their system before you turn it on.   We know that "make chec=
k"
>> does not work across the board.  It never has.  That is why it wasn't
>> turned on previously.
>=20
> It's not quite so simple, really.  Currently, "make check" does a lot
> of building in the process of testing things, and these test harnesses
> really should be built and tested the same way as other parts of the
> code base are built and tested -- otherwise the code will just rot, as
> it clearly has already.

I don't see how requiring that builder owners demonstrate that "make
check" works on their system prior to adding "make check" to that system
in the buildbot is contrary to testing the test harnesses.

When we are processing 50+ patchsets a day through buildbot, why should
we break everything that is unrelated to the test harnesses while
waiting to determine that the test harnesses can in fact complete
successfully?

I will also note that there are other aspects of the OpenAFS build
process that are not tested by buildbot:

1. documentation

2. installer packaging

They are not turned on because doing so significantly increases the
build times for each patchset.   The rate of change of documentation at
this point is also so low that it is more efficient to test each
patchset manually.

Jeffrey Altman


--------------enig99729CAFB31DF0EF7D636EC8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)

iQEcBAEBAgAGBQJPhHG/AAoJENxm1CNJffh4dLEH+QESa2L9qyt5ujXHHBlbW6SJ
EUW3eDFVzEDjEQ1ChSw+0Hf37GVxjL7eOfW2vfAiUAdTR629bzHCG6fIGqj8buLq
3AMw/VBulXobIOZFTkvXMUNc9leEdbArcUj/Gndzf9SUP75fKDLTPxZe/Dbhv/4s
tmaEf6lIh+xvwM1/8Tw5f73KOI0JwyQOhbDRobkmTohiUbDn6mY2w5zW53mKeVoi
BtzEEDs/U8nNOA4jyfvSxDgJDOb2f2Oi8rPUxvoA/k397z5Ain9DeSA3wc9zexVG
INZrI2AmUWXxX7NzPEbF6uqG5Oc+k6l+A65s5i2z6gyaftVwunmIe2d81iuHbXg=
=L3MW
-----END PGP SIGNATURE-----

--------------enig99729CAFB31DF0EF7D636EC8--