[OpenAFS-devel] Re: adding "make check" to build slaves

Andrew Deason adeason@sinenomine.net
Tue, 10 Apr 2012 12:51:24 -0500


On Tue, 10 Apr 2012 08:17:14 -0400
Jeffrey Altman <jaltman@secure-endpoints.com> wrote:

> What should not be done is turn on a new feature that *might* break
> the existing system and generate additional risk when the builders are
> 30 or 40 patchsets deep in builds.

How is adding 'make check' as a non-failing step going to break
anything? Just only add it to the 'fast' builders, or put it on a
separate periodic (non-gerrit) build schedule.

Asking people to manually run the tests doesn't scale well, if there are
a bunch of things to fix and we keep asking them to try new patches.

-- 
Andrew Deason
adeason@sinenomine.net