[OpenAFS-devel] Re: adding "make check" to build slaves

[Jeffrey Altman]

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig3B8D09EE230455370666494C
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 4/10/2012 1:49 PM, Garrett Wollman wrote:
> <<On Tue, 10 Apr 2012 13:45:30 -0400, Jeffrey Altman <jaltman@secure-en=
dpoints.com> said:
>=20
>> I don't see how requiring that builder owners demonstrate that "make
>> check" works on their system prior to adding "make check" to that syst=
em
>> in the buildbot is contrary to testing the test harnesses.
>=20
> You are failing to make the fundamental distinction between testing
> that the test harnesses build, which is simple, takes very little
> time, and should just be done as a part of the normal build process,
> and testing that the tests pass, which is not necessarily simple,
> quick, or appropriate to do for every change.

The distinction is irrelevant to my point.   Do not add new requirements
to the builders if it is not known that the requirements are met at the
time they are added.

Perhaps you do not understand the impact that such a change has on the
review process because you are not actively involved in reviewing
patchsets.  All of the buildbot builders to which a patchset is assigned
must successfully complete the build script without errors in order for
the patchset to be marked "verified" by the buildbot coordinator.   If
the patchset is not marked verified, the gatekeepers (or other
reviewers) must go through the buildbot output manually to determine if
the failure is of consequence to the patchset being reviewed.   This
additional workload is a significant burden.

If you would be willing to take on this burden, please register with
gerrit to receive e-mail notification of all patchset submissions and
updates.  Then when a buildbot update is posted, check to see whether it
verified the patchset or not, and if not, perform a manual review of the
failed builder output.

Jeffrey Altman



--------------enig3B8D09EE230455370666494C
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)

iQEcBAEBAgAGBQJPhHVFAAoJENxm1CNJffh4qAoIAKHKK24Gusf0W7tWYPvo0lSM
0kXqxIt2pDBCE8ymrFGWKd2VM65sl80xANby9+nffDTNJjTtyDjZLfl8/BHY622P
rJKn9Dh9BY2FKGrUdyZSu607MZEtHykOzQH/cYLBUqIZMZ3YsywBpcUebhyKP7fs
6GGJaQRxmhvQcLJDnvTjAUSbe0EvQNROZNGbWXxsRByuGCWjgxVAynnJ+9GZQoWR
qO2jijmcZMwIMRcIWuTi8TxT0YswT9/YOjm7Xz2g/jJ4tfPT9zHDHk225aQcHdn5
dsoWmbpdKtepC0uzGT+Wkb+SRIvO7BzI5E6BR6qsg95N9xqeG0/3aeQ9dnr5a+A=
=9Gr/
-----END PGP SIGNATURE-----

--------------enig3B8D09EE230455370666494C--