[OpenAFS-devel] Re: adding "make check" to build slaves

Andrew Deason adeason@sinenomine.net
Thu, 12 Apr 2012 13:07:39 -0500


On Wed, 11 Apr 2012 19:05:32 -0400
Jason Edgecombe <jason@rampaginggeek.com> wrote:

> ok, so what's next?
> 
> Is it good enough to write a script that sets the right variables and 
> runs the tests?

Yes; at least, that's what I was thinking. Apparently tests/Makefile.in
already tries to do this, by just setting LD_LIBRARY_PATH. Instead of
running 'LD_LIBRARY_PATH=@TOP_OBJDIR@/lib ./runtests bar', it should
probably run something like './libwrap @TOP_OBJDIR@/lib ./runtests bar'
and have some 'libwrap' script that sets the right variables according
to the platform (platform obtained via @AFS_SYSNAME@ from autoconf).

Or runtests itself could set this, but I assume just a little bit of
shell is easier. I haven't thought any of this through or anything; just
mentioning the idea.

-- 
Andrew Deason
adeason@sinenomine.net