[OpenAFS-devel] Compilation error on FreeBSD 9.0 buildslave

Derrick Brashear shadow@gmail.com
Fri, 26 Oct 2012 16:57:55 -0400


On Fri, Oct 26, 2012 at 1:01 PM, Marc Dionne <marc.c.dionne@gmail.com> wrote:
> On Fri, Oct 26, 2012 at 12:40 PM, Benjamin Kaduk <kaduk@mit.edu> wrote:
>> On Fri, 26 Oct 2012, Marc Dionne wrote:
>>
>>> On Fri, Oct 26, 2012 at 3:45 AM, Simon Wilkinson
>>> <simonxwilkinson@gmail.com> wrote:
>>>>
>>>>
>>>>> I don't have time to investigate a fix for this, but it's caused by
>>>>> having two distinct declarations for the same uninitialized data
>>>>> object, which FreeBSD does not allow in kernel code.  If someone else
>>>>> can propose a fix, poke me through Gerrit and I'll review.
>>>>
>>>>
>>>> With eca07c108cc61fc9a6da720848e1beb78833f670, neither
>>>> rx_incomingCallQueue or rx_idleServerQueue are defined in rx_globals.h. In
>>>> fact, the only reference to rx_incomingCallQueue in the tree is in rx.c.
>>>>
>>>> I'm somewhat puzzled by this build failure, unless the FreeBSD builder
>>>> isn't cleaning its tree properly between builds?
>>>
>>>
>>> That would be my guess.  Looking at the buildbot log, neither rx.o or
>>> rx_globals.o are rebuilt during the failed build.  So we probably have
>>> an rx_globals.o that dates from before that change, while rx.o was
>>> rebuilt after the change.
>>
>>
>> Hmm, I thought that the builders were supposed to 'git clean -xfd' before
>> each build?
>
> At least this one is currently doing:
>    git clean -X -f -e '!.buildbot-sourcedata'
>
> which doesn't have -d and doesn't remove the libafs/MODLOAD directory
> and its object files.

all of them do that except rhel6 and intel macos. what version of git
is on the freebsd builder?


-- 
Derrick