[OpenAFS-devel] Re: having trouble compiling openafs kernel
module in kernel 4.5
Gary Gatling
gsgatlin@ncsu.edu
Fri, 3 Jun 2016 16:27:39 -0400
--001a113dcfd8df1ce80534658def
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
I'm pretty sure the patch was applied correctly.
0003-Linux-4.5-get_link-instead-of-follow_link-put_link.patch
tar -xvjf openafs-1.6.18-src.tar.bz2
cd openafs-1.6.18/
patch -p1 < ../0001-Linux-3.13-Check-return-value-from-bdi_init.patch
patching file src/afs/LINUX/osi_vfsops.c
patch -p1 < ../0002-Linux-4.5-no-highmem-in-symlink-ops.patch
patching file acinclude.m4
patching file src/afs/LINUX/osi_vnodeops.c
patch -p1 < ../0003-Linux-4.5-get_link-instead-of-follow_link-put_link.patc=
h
patching file acinclude.m4
patching file src/afs/LINUX/osi_vnodeops.c
patch -p1 < ../0005-Linux-4.5-don-t-access-i_mutex-directly.patch
patching file acinclude.m4
patching file src/afs/LINUX/osi_compat.h
patching file src/afs/LINUX/osi_vnodeops.c
./configure
--with-linux-kernel-headers=3D/usr/src/kernels/4.5.5-201.fc23.x86_64
make
same error message.
/home/gsgatlin/redhat/sources/openafs-1.6.18/src/libafs/MODLOAD-4.5.5-201.f=
c23.x86_64-MP/osi_vnodeops.c:1935:5:
error: implicit declaration of function =E2=80=98nd_set_link=E2=80=99
[-Werror=3Dimplicit-function-declaration]
nd_set_link(nd, name);
^
patch contents:
https://paste.fedoraproject.org/374248/14649855/
Also, if there were concerns that I am a freeloader / leech I did donate
some money to the openafs paypal.
Thanks,
On Fri, Jun 3, 2016 at 3:57 PM, Michael La=C3=9F <lass@mail.upb.de> wrote:
> Hi,
>
> Am Freitag, den 03.06.2016, 21:13 +0200 schrieb Stephan Wiesand:
> > On Jun 3, 2016, at 20:31 , Gary Gatling wrote:
> > > Thanks for any ideas anyone may have on how to compile openafs on 4.5
> > > kernel. I know its possible since Arch Linux pulled it off.
> >
> > Alas, if so, they haven't bothered submitting the magic patch to
> > gerrit.openafs.org. The changes under
> > https://gerrit.openafs.org/#/q/status:open+project:openafs+branch:mas
> > ter+topic:linux45 are all we have. I'll take your message as a report
> > that those changes are not sufficient to cope with Linux 4.5. It
> > makes me very sad.
>
> As I am maintaining the Arch Linux package: There is no magic patch,
> only the aforementioned patches are applied (gerrit 12264, 12265,
> 12268, 12274) and the kernel module compiles and works (as far as I can
> tell) with Linux 4.5.4.
>
> The first issue in the linked compile log is the following:
> >
> /home/gsgatlin/redhat/sources/openafs-1.6.18/src/libafs/MODLOAD-4.5.5-201=
.fc23.x86_64-MP/osi_vnodeops.c:
> In function =E2=80=98afs_linux_follow_link=E2=80=99:
> >
> /home/gsgatlin/redhat/sources/openafs-1.6.18/src/libafs/MODLOAD-4.5.5-201=
.fc23.x86_64-MP/osi_vnodeops.c:1935:5:
> error: implicit declaration of function =E2=80=98nd_set_link=E2=80=99
> [-Werror=3Dimplicit-function-declaration]
> > nd_set_link(nd, name);
>
> This particular error occurs if 0003-Linux-4.5-get_link-instead-of-
> follow_link-put_link.patch (gerrit 12265) is not applied.
>
> Cheers,
> Michael
> _______________________________________________
> OpenAFS-devel mailing list
> OpenAFS-devel@openafs.org
> https://lists.openafs.org/mailman/listinfo/openafs-devel
>
--001a113dcfd8df1ce80534658def
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">I'm pretty sure the patch was applied correctly.<div><=
div>0003-Linux-4.5-get_link-instead-of-follow_link-put_link.patch</div></di=
v><div><br></div><div>tar -xvjf openafs-1.6.18-src.tar.bz2<br></div><div>cd=
openafs-1.6.18/<br></div><div>patch -p1 < ../0001-Linux-3.13-Check-retu=
rn-value-from-bdi_init.patch<br></div><div>patching file src/afs/LINUX/osi_=
vfsops.c<br></div><div><div>patch -p1 < ../0002-Linux-4.5-no-highmem-in-=
symlink-ops.patch</div><div>patching file acinclude.m4</div><div>patching f=
ile src/afs/LINUX/osi_vnodeops.c</div></div><div><div>patch -p1 < ../000=
3-Linux-4.5-get_link-instead-of-follow_link-put_link.patch</div><div>patchi=
ng file acinclude.m4</div><div>patching file src/afs/LINUX/osi_vnodeops.c</=
div></div><div><div>patch -p1 < ../0005-Linux-4.5-don-t-access-i_mutex-d=
irectly.patch</div><div>patching file acinclude.m4</div><div>patching file =
src/afs/LINUX/osi_compat.h</div><div>patching file src/afs/LINUX/osi_vnodeo=
ps.c</div></div><div>./configure --with-linux-kernel-headers=3D/usr/src/ker=
nels/4.5.5-201.fc23.x86_64<br></div><div>make</div><div><br></div><div>same=
error message.</div><div><br></div><div><div>/home/gsgatlin/redhat/sources=
/openafs-1.6.18/src/libafs/MODLOAD-4.5.5-201.fc23.x86_64-MP/osi_vnodeops.c:=
1935:5: error: implicit declaration of function =E2=80=98nd_set_link=E2=80=
=99 [-Werror=3Dimplicit-function-declaration]</div><div>=C2=A0 =C2=A0 =C2=
=A0nd_set_link(nd, name);</div><div>=C2=A0 =C2=A0 =C2=A0^</div></div><div><=
br></div><div><br></div><div>patch contents:</div><div><br></div><div><a hr=
ef=3D"https://paste.fedoraproject.org/374248/14649855/">https://paste.fedor=
aproject.org/374248/14649855/</a><br></div><div><br></div><div>Also, if the=
re were concerns that I am a freeloader / =C2=A0leech I did donate some mon=
ey to the openafs paypal.</div><div><br></div><div>Thanks,</div></div><div =
class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Fri, Jun 3, 2016 at=
3:57 PM, Michael La=C3=9F <span dir=3D"ltr"><<a href=3D"mailto:lass@mai=
l.upb.de" target=3D"_blank">lass@mail.upb.de</a>></span> wrote:<br><bloc=
kquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #cc=
c solid;padding-left:1ex">Hi,<br>
<span class=3D""><br>
Am Freitag, den 03.06.2016, 21:13 +0200 schrieb Stephan Wiesand:<br>
> On Jun 3, 2016, at 20:31 , Gary Gatling wrote:<br>
</span><span class=3D"">> > Thanks for any ideas anyone may have on h=
ow to compile openafs on 4.5<br>
> > kernel. I know its possible since Arch Linux pulled it off.<br>
><br>
> Alas, if so, they haven't bothered submitting the magic patch to<b=
r>
> <a href=3D"http://gerrit.openafs.org" rel=3D"noreferrer" target=3D"_bl=
ank">gerrit.openafs.org</a>. The changes under<br>
> <a href=3D"https://gerrit.openafs.org/#/q/status:open+project:openafs+=
branch:mas" rel=3D"noreferrer" target=3D"_blank">https://gerrit.openafs.org=
/#/q/status:open+project:openafs+branch:mas</a><br>
> ter+topic:linux45 are all we have. I'll take your message as a rep=
ort<br>
> that those changes are not sufficient to cope with Linux 4.5. It<br>
> makes me very sad.<br>
<br>
</span>As I am maintaining the Arch Linux package: There is no magic patch,=
<br>
only the aforementioned patches are applied (gerrit 12264, 12265,<br>
12268, 12274) and the kernel module compiles and works (as far as I can<br>
tell) with Linux 4.5.4.<br>
<br>
The first issue in the linked compile log is the following:<br>
> /home/gsgatlin/redhat/sources/openafs-1.6.18/src/libafs/MODLOAD-4.5.5-=
201.fc23.x86_64-MP/osi_vnodeops.c: In function =E2=80=98afs_linux_follow_li=
nk=E2=80=99:<br>
> /home/gsgatlin/redhat/sources/openafs-1.6.18/src/libafs/MODLOAD-4.5.5-=
201.fc23.x86_64-MP/osi_vnodeops.c:1935:5: error: implicit declaration of fu=
nction =E2=80=98nd_set_link=E2=80=99 [-Werror=3Dimplicit-function-declarati=
on]<br>
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0nd_set_link(nd, name);<br>
<br>
This particular error occurs if 0003-Linux-4.5-get_link-instead-of-<br>
follow_link-put_link.patch (gerrit 12265) is not applied.<br>
<br>
Cheers,<br>
Michael<br>
<div class=3D"HOEnZb"><div class=3D"h5">___________________________________=
____________<br>
OpenAFS-devel mailing list<br>
<a href=3D"mailto:OpenAFS-devel@openafs.org">OpenAFS-devel@openafs.org</a><=
br>
<a href=3D"https://lists.openafs.org/mailman/listinfo/openafs-devel" rel=3D=
"noreferrer" target=3D"_blank">https://lists.openafs.org/mailman/listinfo/o=
penafs-devel</a><br>
</div></div></blockquote></div><br></div>
--001a113dcfd8df1ce80534658def--