[OpenAFS-devel] Latest build kernel panic on AIX 6.1 6100-09-12

Ben Huntsman ben@huntsmans.net
Tue, 16 Aug 2022 15:19:39 +0000


--_000_MWHPR0701MB36745A4BE3E25403A2BFD64CA76B9MWHPR0701MB3674_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hey there!
   Thank you, I will give that a try.

   Dumb question though, how do I cherry-pick that commit into my topic bra=
nch?

Thanks!

-Ben


________________________________
From: Benjamin Kaduk <kaduk@mit.edu>
Sent: Tuesday, August 16, 2022 7:56 AM
To: Jeffrey E Altman <jaltman@auristor.com>
Cc: Ben Huntsman <ben@huntsmans.net>; openafs-devel@openafs.org <openafs-de=
vel@openafs.org>
Subject: Re: [OpenAFS-devel] Latest build kernel panic on AIX 6.1 6100-09-1=
2

On Tue, Aug 16, 2022 at 08:34:09AM -0400, Jeffrey E Altman wrote:
> On 8/16/2022 2:50 AM, Ben Huntsman (ben@huntsmans.net) wrote:
> > CRASH INFORMATION:
> > CPU 0 CSA F00000002FF47600 at time of crash, error code for LEDs: 30000=
000
> > pvthread+01DB00 STACK:
> > [0000E864]___memset64+00005C ()
> > [F1000000C04C1AF4]rxevent_alloc+000094 ()
> >
> Try fixing the misplaced #endif.
>
>
> diff --git a/src/rx/rx_event.c b/src/rx/rx_event.c
> --- a/src/rx/rx_event.c
> +++ b/src/rx/rx_event.c
> @@ -126,8 +126,8 @@ rxevent_alloc(void)
>         mrec->next =3D freeEvents.mallocs;
>         freeEvents.mallocs =3D mrec;
>         MUTEX_EXIT(&freeEvents.lock);
> -#endif
>         ev =3D &evlist[0];
> +#endif
>      } else {
>         ev =3D opr_queue_Shift(&freeEvents.list, struct rxevent, q);
>         MUTEX_EXIT(&freeEvents.lock);

Well that's a pretty obvious fix, yes.
Tracking at https://gerrit.openafs.org/15106 for now.

-Ben

--_000_MWHPR0701MB36745A4BE3E25403A2BFD64CA76B9MWHPR0701MB3674_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
1">
<style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-bo=
ttom:0;} </style>
</head>
<body dir=3D"ltr">
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);" class=3D"elementToProof">
Hey there!</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);" class=3D"elementToProof">
&nbsp; &nbsp;Thank you, I will give that a try.</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);" class=3D"elementToProof">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);" class=3D"elementToProof">
&nbsp; &nbsp;Dumb question though, how do I cherry-pick that commit into my=
 topic branch?</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);" class=3D"elementToProof">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);" class=3D"elementToProof">
Thanks!<br>
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);" class=3D"elementToProof">
-Ben</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);" class=3D"elementToProof">
<br>
</div>
<div id=3D"signature_bookmark"></div>
<div id=3D"appendonsend"></div>
<div style=3D"font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12p=
t; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex=3D"-1" style=3D"display:inline-block; width:98%">
<div id=3D"divRplyFwdMsg" dir=3D"ltr"><font face=3D"Calibri, sans-serif" co=
lor=3D"#000000" style=3D"font-size:11pt"><b>From:</b> Benjamin Kaduk &lt;ka=
duk@mit.edu&gt;<br>
<b>Sent:</b> Tuesday, August 16, 2022 7:56 AM<br>
<b>To:</b> Jeffrey E Altman &lt;jaltman@auristor.com&gt;<br>
<b>Cc:</b> Ben Huntsman &lt;ben@huntsmans.net&gt;; openafs-devel@openafs.or=
g &lt;openafs-devel@openafs.org&gt;<br>
<b>Subject:</b> Re: [OpenAFS-devel] Latest build kernel panic on AIX 6.1 61=
00-09-12</font>
<div>&nbsp;</div>
</div>
<div class=3D"BodyFragment"><font size=3D"2"><span style=3D"font-size:11pt"=
>
<div class=3D"PlainText">On Tue, Aug 16, 2022 at 08:34:09AM -0400, Jeffrey =
E Altman wrote:<br>
&gt; On 8/16/2022 2:50 AM, Ben Huntsman (ben@huntsmans.net) wrote:<br>
&gt; &gt; CRASH INFORMATION:<br>
&gt; &gt; CPU 0 CSA F00000002FF47600 at time of crash, error code for LEDs:=
 30000000<br>
&gt; &gt; pvthread+01DB00 STACK:<br>
&gt; &gt; [0000E864]___memset64+00005C ()<br>
&gt; &gt; [F1000000C04C1AF4]rxevent_alloc+000094 ()<br>
&gt; &gt;<br>
&gt; Try fixing the misplaced #endif.&nbsp;<br>
&gt; <br>
&gt; <br>
&gt; diff --git a/src/rx/rx_event.c b/src/rx/rx_event.c<br>
&gt; --- a/src/rx/rx_event.c<br>
&gt; +++ b/src/rx/rx_event.c<br>
&gt; @@ -126,8 +126,8 @@ rxevent_alloc(void)<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; mrec-&gt;next =3D freeEvent=
s.mallocs;<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; freeEvents.mallocs =3D mrec=
;<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; MUTEX_EXIT(&amp;freeEvents.=
lock);<br>
&gt; -#endif<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ev =3D &amp;evlist[0];<br>
&gt; +#endif<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp; } else {<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ev =3D opr_queue_Shift(&amp=
;freeEvents.list, struct rxevent, q);<br>
&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; MUTEX_EXIT(&amp;freeEvents.=
lock);<br>
<br>
Well that's a pretty obvious fix, yes.<br>
</div>
<div class=3D"PlainText elementToProof">Tracking at <a href=3D"https://gerr=
it.openafs.org/15106" data-auth=3D"NotApplicable">
https://gerrit.openafs.org/15106</a> for now.<br>
</div>
<div class=3D"PlainText"><br>
-Ben<br>
</div>
</span></font></div>
</body>
</html>

--_000_MWHPR0701MB36745A4BE3E25403A2BFD64CA76B9MWHPR0701MB3674_--