[OpenAFS-devel] Pulling up changes to stable
Ben Huntsman
ben@huntsmans.net
Fri, 3 Mar 2023 23:36:47 +0000
--_000_MWHPR0701MB367405475C46702FC6847A16A7B39MWHPR0701MB3674_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Hi Stephan!
Thank you for the reply! I am happy to provide that information. To be=
clear, what are you looking for when you say "change numbers"? The 5-digi=
t number from Gerrit? The Change-ID hash from the commit? Or the sha of t=
he commit to master itself?
Thank you again!
-Ben
________________________________
From: Stephan Wiesand <stephan.wiesand@desy.de>
Sent: Friday, March 3, 2023 10:12 AM
To: Ben Huntsman <ben@huntsmans.net>
Cc: openafs-devel@openafs.org <openafs-devel@openafs.org>
Subject: Re: [OpenAFS-devel] Pulling up changes to stable
Hi Ben,
> On 3. Mar 2023, at 18:13, Ben Huntsman <ben@huntsmans.net> wrote:
>
> Hi there!
> Thank you for accepting the patches I submitted to get OpenAFS working=
on AIX 7.2-7.3, as well as the previous ones!
thank you for whipping those up.
> Now that they're all there in the master branch, what needs to be done=
to pull them up into an upcoming stable branch?
These changes are on my list of things I want to get into stable. I'm just =
slow.
> I read the GitDevelopers page, but is it ok for anyone to push patches =
to Gerrit for an upcoming stable, or is there some additional review proces=
s?
In principle it's ok, provided that those patches are clean cherry-picks fr=
om master. In practice, it causes extra work if a change pulled up like thi=
s touches a file already modified by any other change in the queue. In addi=
tion, you'll sometimes (or rather often) find that the change from master d=
oesn't apply cleanly to stable, and either needs to be modified or (preferr=
ably) be supplemented by more changes from master not yet on stable.
Mind you, you're absolutely free to submit those pull-ups yourself. The mos=
t appreciated way you can help though is to provide a list of change number=
s you'd like to see in an upcoming stable release. And keep poking...
Best regards,
Stephan
>
> Thank you much!
>
> -Ben
--
Stephan Wiesand
DESY - DV -
Platanenallee 6
15738 Zeuthen, Germany
--_000_MWHPR0701MB367405475C46702FC6847A16A7B39MWHPR0701MB3674_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
<style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-bo=
ttom:0;} </style>
</head>
<body dir=3D"ltr">
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof">
Hi Stephan!</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof">
Thank you for the reply! I am happy to provide that info=
rmation. To be clear, what are you looking for when you say "cha=
nge numbers"? The 5-digit number from Gerrit? The Change-I=
D hash from the commit? Or the sha of the commit to master itself?</d=
iv>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof">
Thank you again!</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof">
-Ben</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof">
<br>
</div>
<div id=3D"appendonsend"></div>
<hr style=3D"display:inline-block;width:98%" tabindex=3D"-1">
<div id=3D"divRplyFwdMsg" dir=3D"ltr"><font face=3D"Calibri, sans-serif" st=
yle=3D"font-size:11pt" color=3D"#000000"><b>From:</b> Stephan Wiesand <s=
tephan.wiesand@desy.de><br>
<b>Sent:</b> Friday, March 3, 2023 10:12 AM<br>
<b>To:</b> Ben Huntsman <ben@huntsmans.net><br>
<b>Cc:</b> openafs-devel@openafs.org <openafs-devel@openafs.org><br>
<b>Subject:</b> Re: [OpenAFS-devel] Pulling up changes to stable</font>
<div> </div>
</div>
<div class=3D"BodyFragment"><font size=3D"2"><span style=3D"font-size:11pt;=
">
<div class=3D"PlainText">Hi Ben,<br>
<br>
> On 3. Mar 2023, at 18:13, Ben Huntsman <ben@huntsmans.net> wrote=
:<br>
> <br>
> Hi there!<br>
> Thank you for accepting the patches I submitted to g=
et OpenAFS working on AIX 7.2-7.3, as well as the previous ones!<br>
<br>
thank you for whipping those up.<br>
<br>
> Now that they're all there in the master branch, wha=
t needs to be done to pull them up into an upcoming stable branch?<br>
<br>
These changes are on my list of things I want to get into stable. I'm just =
slow.<br>
<br>
> I read the GitDevelopers page, but is it ok for anyone to =
push patches to Gerrit for an upcoming stable, or is there some additional =
review process?<br>
<br>
In principle it's ok, provided that those patches are clean cherry-picks fr=
om master. In practice, it causes extra work if a change pulled up like thi=
s touches a file already modified by any other change in the queue. In addi=
tion, you'll sometimes (or rather
often) find that the change from master doesn't apply cleanly to stable, a=
nd either needs to be modified or (preferrably) be supplemented by more cha=
nges from master not yet on stable.<br>
<br>
Mind you, you're absolutely free to submit those pull-ups yourself. The mos=
t appreciated way you can help though is to provide a list of change number=
s you'd like to see in an upcoming stable release. And keep poking...<br>
<br>
Best regards,<br>
Stephan<br>
<br>
> <br>
> Thank you much!<br>
> <br>
> -Ben<br>
<br>
<br>
-- <br>
Stephan Wiesand<br>
DESY - DV -<br>
Platanenallee 6<br>
15738 Zeuthen, Germany<br>
<br>
<br>
<br>
</div>
</span></font></div>
</body>
</html>
--_000_MWHPR0701MB367405475C46702FC6847A16A7B39MWHPR0701MB3674_--