[OpenAFS] Problems with 1.3.61 in Windows 2000
Jeffrey Altman
jaltman@columbia.edu
Tue, 23 Mar 2004 18:59:30 -0500
This is a cryptographically signed message in MIME format.
--------------ms050005000103020807070708
Content-Type: multipart/alternative;
boundary="------------040804060201050909090709"
This is a multi-part message in MIME format.
--------------040804060201050909090709
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
I just performed a quick audit of the afslogon.c code and fixed several
obvious
problems including the referencing of uninitialized char[] buffers when
generating
strings with sprintf() that most definitely could be the cause of the
problem.
I have uploaded test builds to
/afs/athena.mit.edu/user/j/a/jaltman/Public/OpenAFS/
http://web.mit.edu/~jaltman/Public/OpenAFS/
OpenAFSforWindows-20040323-01.exe
OpenAFSforWindows-DEBUG-20040323-01.exe
Please try them out.
Jeffrey Altman
Jeffrey Altman wrote:
> Fact: the afslogon.dll is loaded by winlogin.exe whenever the
> "TransarcAFSDaemon"
> is listed within
> HKLM\SYSTEM\CurrentControlSet\Control\NetworkProvider\ProviderOrder
> "Order".
> This is true whether or not Integrated Logon is being used.
>
> Fact: the afslogon.dll has not been touched by anyone since the 1.2.8
> distribution
>
> Fact: the 1.3.50 and higher versions of OpenAFS are compiled using
> the VS.NET 2003
> compiler including the buffer overrun detection option. The 1.2.x
> versions were compiled
> with the VC++ 6.0 compiler which did not have buffer overrun detection.
>
> Hypothesis: There are buffer overruns taking place within afslogon.dll
> which have always
> been there and which are only triggered in some environments.
> However, previously
> they were never caught. Now when they are caught an exception is
> thrown which is
> causing winlogin.exe to halt.
>
> Please install the DEBUG version of the installer from
> http://web.mit.edu/~jaltman/Public/OpenAFS/
> and get me a crash log. Hopefully this will point out the cause of
> the problem.
>
> Jeffrey Altman
>
--------------040804060201050909090709
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7bit
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
<font face="Bitstream Cyberbit">I just performed a quick audit of the
afslogon.c code and fixed several obvious<br>
problems including the referencing of uninitialized char[] buffers when
generating<br>
strings with sprintf() that most definitely could be the cause of the
problem.<br>
<br>
I have uploaded test builds to <br>
<br>
/afs/athena.mit.edu/user/j/a/jaltman/Public/OpenAFS/<br>
<a class="moz-txt-link-freetext" href="http://web.mit.edu/~jaltman/Public/OpenAFS/">http://web.mit.edu/~jaltman/Public/OpenAFS/</a><br>
<br>
OpenAFSforWindows-20040323-01.exe<br>
OpenAFSforWindows-DEBUG-20040323-01.exe<br>
<br>
Please try them out.<br>
<br>
Jeffrey Altman<br>
<br>
<br>
Jeffrey Altman wrote:<br>
</font>
<blockquote cite="mid4060B43C.6070509@columbia.edu" type="cite">
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
<font face="Bitstream Cyberbit">Fact: the afslogon.dll is loaded by
winlogin.exe whenever the "TransarcAFSDaemon" <br>
is listed within
HKLM\SYSTEM\CurrentControlSet\Control\NetworkProvider\ProviderOrder
"Order".<br>
This is true whether or not Integrated Logon is being used.<br>
<br>
Fact: the afslogon.dll has not been touched by anyone since the 1.2.8
distribution<br>
<br>
Fact: the 1.3.50 and higher versions of OpenAFS are compiled using the
VS.NET 2003<br>
compiler including the buffer overrun detection option. The 1.2.x
versions were compiled<br>
with the VC++ 6.0 compiler which did not have buffer overrun detection.<br>
<br>
Hypothesis: There are buffer overruns taking place within afslogon.dll
which have always<br>
been there and which are only triggered in some environments. However,
previously <br>
they were never caught. Now when they are caught an exception is
thrown which is<br>
causing winlogin.exe to halt. <br>
<br>
Please install the DEBUG version of the installer from
<a class="moz-txt-link-freetext"
href="http://web.mit.edu/%7Ejaltman/Public/OpenAFS/">http://web.mit.edu/~jaltman/Public/OpenAFS/</a><br>
and get me a crash log. Hopefully this will point out the cause of the
problem.<br>
<br>
Jeffrey Altman<br>
</font><br>
</blockquote>
</body>
</html>
--------------040804060201050909090709--
--------------ms050005000103020807070708
Content-Type: application/x-pkcs7-signature; name="smime.p7s"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="smime.p7s"
Content-Description: S/MIME Cryptographic Signature
MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIJUDCC
AwYwggJvoAMCAQICAwpxijANBgkqhkiG9w0BAQQFADCBkjELMAkGA1UEBhMCWkExFTATBgNV
BAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMQ8wDQYDVQQKEwZUaGF3dGUx
HTAbBgNVBAsTFENlcnRpZmljYXRlIFNlcnZpY2VzMSgwJgYDVQQDEx9QZXJzb25hbCBGcmVl
bWFpbCBSU0EgMjAwMC44LjMwMB4XDTAzMDczMDAyMDkyOFoXDTA0MDcyOTAyMDkyOFowRjEf
MB0GA1UEAxMWVGhhd3RlIEZyZWVtYWlsIE1lbWJlcjEjMCEGCSqGSIb3DQEJARYUamFsdG1h
bkBjb2x1bWJpYS5lZHUwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDBtDG6ZyGA
sK+rZOfKPKGBn6oCTLYSLk/mpeX9QTmTG71qh308KUeN35qqoRXjLvscfw6NPOYXiuxE/RqL
sx7WKEnK3C4gzzpioCTX1b7o4M7YbpvCRBFPE9Jgsd0yz2EN+mk/pPuK1GP+iQNot2m4A56A
aPe6F5T25GqffU535GNIdAtWPao6wHcOm17se25ny/TNzb9mlA4UzYl9XP7MF1fkpJyaDDAy
DNNTSSjxBdPVs2EaYq1p/xadXbIpysQiySXAxoeiZusgJopRHLcBsBmmY9QVD4QnUqZVmfJ5
f1CiNri5vlexKCmdFSrxMLuoLr4EQZCECdusp6ZnIt75AgMBAAGjMTAvMB8GA1UdEQQYMBaB
FGphbHRtYW5AY29sdW1iaWEuZWR1MAwGA1UdEwEB/wQCMAAwDQYJKoZIhvcNAQEEBQADgYEA
DPKe/CuAgEUxsrPskJQx2fL6soAEG2iqrqOGIRREHDaXWDBNMEWEbOEMLvh3+yhqHOUc9x3r
2IfsP/XHnujaqsMVXLagokVTnpPN675wv8LZ8hLHblLnykaTCq6RZpVskh2iAiJwpYMcKNF6
jyYaQyGHBGT3PK8uVGVCG4Pp9k4wggMGMIICb6ADAgECAgMKcYowDQYJKoZIhvcNAQEEBQAw
gZIxCzAJBgNVBAYTAlpBMRUwEwYDVQQIEwxXZXN0ZXJuIENhcGUxEjAQBgNVBAcTCUNhcGUg
VG93bjEPMA0GA1UEChMGVGhhd3RlMR0wGwYDVQQLExRDZXJ0aWZpY2F0ZSBTZXJ2aWNlczEo
MCYGA1UEAxMfUGVyc29uYWwgRnJlZW1haWwgUlNBIDIwMDAuOC4zMDAeFw0wMzA3MzAwMjA5
MjhaFw0wNDA3MjkwMjA5MjhaMEYxHzAdBgNVBAMTFlRoYXd0ZSBGcmVlbWFpbCBNZW1iZXIx
IzAhBgkqhkiG9w0BCQEWFGphbHRtYW5AY29sdW1iaWEuZWR1MIIBIjANBgkqhkiG9w0BAQEF
AAOCAQ8AMIIBCgKCAQEAwbQxumchgLCvq2TnyjyhgZ+qAky2Ei5P5qXl/UE5kxu9aod9PClH
jd+aqqEV4y77HH8OjTzmF4rsRP0ai7Me1ihJytwuIM86YqAk19W+6ODO2G6bwkQRTxPSYLHd
Ms9hDfppP6T7itRj/okDaLdpuAOegGj3uheU9uRqn31Od+RjSHQLVj2qOsB3Dpte7HtuZ8v0
zc2/ZpQOFM2JfVz+zBdX5KScmgwwMgzTU0ko8QXT1bNhGmKtaf8WnV2yKcrEIsklwMaHombr
ICaKURy3AbAZpmPUFQ+EJ1KmVZnyeX9Qoja4ub5XsSgpnRUq8TC7qC6+BEGQhAnbrKemZyLe
+QIDAQABozEwLzAfBgNVHREEGDAWgRRqYWx0bWFuQGNvbHVtYmlhLmVkdTAMBgNVHRMBAf8E
AjAAMA0GCSqGSIb3DQEBBAUAA4GBAAzynvwrgIBFMbKz7JCUMdny+rKABBtoqq6jhiEURBw2
l1gwTTBFhGzhDC74d/soahzlHPcd69iH7D/1x57o2qrDFVy2oKJFU56Tzeu+cL/C2fISx25S
58pGkwqukWaVbJIdogIicKWDHCjReo8mGkMhhwRk9zyvLlRlQhuD6fZOMIIDODCCAqGgAwIB
AgIQZkVyt8x09c9jdkWE0C6RATANBgkqhkiG9w0BAQQFADCB0TELMAkGA1UEBhMCWkExFTAT
BgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3
dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lv
bjEkMCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkB
FhxwZXJzb25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAwMDgzMDAwMDAwMFoXDTA0MDgy
NzIzNTk1OVowgZIxCzAJBgNVBAYTAlpBMRUwEwYDVQQIEwxXZXN0ZXJuIENhcGUxEjAQBgNV
BAcTCUNhcGUgVG93bjEPMA0GA1UEChMGVGhhd3RlMR0wGwYDVQQLExRDZXJ0aWZpY2F0ZSBT
ZXJ2aWNlczEoMCYGA1UEAxMfUGVyc29uYWwgRnJlZW1haWwgUlNBIDIwMDAuOC4zMDCBnzAN
BgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEA3jMypmPHCSVFPtJueCdngcXaiBmClw7jRCmKYzUq
bXA8+tyu9+50bzC8M5B/+TRxoKNtmPHDT6Jl2w36S/HW3WGl+YXNVZo1Gp2Sdagnrthy+boC
9tewkd4c6avgGAOofENCUFGHgzzwObSbVIoTh/+zm51JZgAtCYnslGvpoWkCAwEAAaNOMEww
KQYDVR0RBCIwIKQeMBwxGjAYBgNVBAMTEVByaXZhdGVMYWJlbDEtMjk3MBIGA1UdEwEB/wQI
MAYBAf8CAQAwCwYDVR0PBAQDAgEGMA0GCSqGSIb3DQEBBAUAA4GBADGxS0dd+QFx5fVTbF15
1j2YwCYTYoEipxL4IpXoG0m3J3sEObr85vIk65H6vewNKjj3UFWobPcNrUwbvAP0teuiR59s
ogxYjTFCCRFssBpp0SsSskBdavl50OouJd2K5PzbDR+dAvNa28o89kTqJmmHf0iezqWf54TY
yWJirQXGMYID1TCCA9ECAQEwgZowgZIxCzAJBgNVBAYTAlpBMRUwEwYDVQQIEwxXZXN0ZXJu
IENhcGUxEjAQBgNVBAcTCUNhcGUgVG93bjEPMA0GA1UEChMGVGhhd3RlMR0wGwYDVQQLExRD
ZXJ0aWZpY2F0ZSBTZXJ2aWNlczEoMCYGA1UEAxMfUGVyc29uYWwgRnJlZW1haWwgUlNBIDIw
MDAuOC4zMAIDCnGKMAkGBSsOAwIaBQCgggIPMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEw
HAYJKoZIhvcNAQkFMQ8XDTA0MDMyMzIzNTkzMFowIwYJKoZIhvcNAQkEMRYEFJs9FLse84nN
l6ObNDMCmftXYx24MFIGCSqGSIb3DQEJDzFFMEMwCgYIKoZIhvcNAwcwDgYIKoZIhvcNAwIC
AgCAMA0GCCqGSIb3DQMCAgFAMAcGBSsOAwIHMA0GCCqGSIb3DQMCAgEoMIGrBgkrBgEEAYI3
EAQxgZ0wgZowgZIxCzAJBgNVBAYTAlpBMRUwEwYDVQQIEwxXZXN0ZXJuIENhcGUxEjAQBgNV
BAcTCUNhcGUgVG93bjEPMA0GA1UEChMGVGhhd3RlMR0wGwYDVQQLExRDZXJ0aWZpY2F0ZSBT
ZXJ2aWNlczEoMCYGA1UEAxMfUGVyc29uYWwgRnJlZW1haWwgUlNBIDIwMDAuOC4zMAIDCnGK
MIGtBgsqhkiG9w0BCRACCzGBnaCBmjCBkjELMAkGA1UEBhMCWkExFTATBgNVBAgTDFdlc3Rl
cm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMQ8wDQYDVQQKEwZUaGF3dGUxHTAbBgNVBAsT
FENlcnRpZmljYXRlIFNlcnZpY2VzMSgwJgYDVQQDEx9QZXJzb25hbCBGcmVlbWFpbCBSU0Eg
MjAwMC44LjMwAgMKcYowDQYJKoZIhvcNAQEBBQAEggEAb3b1H9J7RdyAi2Vr+u4duG6mqEno
Ol8+ryClrnMKPYieV6P9Am6DgCHiZ9T07gYRjB+lrQDvoXv25t25uZOPym3bG76U6vQpr23c
rFP+zYDDwq4Tdrh7Yg6iKfwiThG6vCeA6lfCcfwiBvNITezNMYcRZnNV6hXoXZvovDIE6LKW
FxpzfVP7urMy6zIHxKcwaReCLfLB2zfqZI1n0HcwM9L5CtAdFyTDmN776aj1S1B4DzJ+rxUA
U87wofGjlfKRj2nSnc2Yc7pj3ZNqCr7coLP+ePsqhG5BFyaZozRAmvggws8sKUSy+IYDQ2eL
z2kry9hY111mPa3kIPCs9CZWCwAAAAAAAA==
--------------ms050005000103020807070708--