[OpenAFS] Problems with 1.3.61 in Windows 2000

[James Burns]

Disregard previous, I'll try the test builds, unless you'd like me to try
out the debug to see for sure what's broken in the "old" one.

-James

On Tue, 23 Mar 2004, Jeffrey Altman wrote:

> I just performed a quick audit of the afslogon.c code and fixed several 
> obvious
> problems including the referencing of uninitialized char[] buffers when 
> generating
> strings with sprintf() that most definitely could be the cause of the 
> problem.
> 
> I have uploaded test builds to
> 
>     /afs/athena.mit.edu/user/j/a/jaltman/Public/OpenAFS/
>     http://web.mit.edu/~jaltman/Public/OpenAFS/
> 
>     OpenAFSforWindows-20040323-01.exe
>     OpenAFSforWindows-DEBUG-20040323-01.exe
> 
> Please try them out.
> 
> Jeffrey Altman
> 
> 
> Jeffrey Altman wrote:
> 
> > Fact: the afslogon.dll is loaded by winlogin.exe whenever the 
> > "TransarcAFSDaemon"
> > is listed within 
> > HKLM\SYSTEM\CurrentControlSet\Control\NetworkProvider\ProviderOrder 
> > "Order".
> > This is true whether or not Integrated Logon is being used.
> >
> > Fact: the afslogon.dll has not been touched by anyone since the 1.2.8 
> > distribution
> >
> > Fact: the 1.3.50  and higher versions of OpenAFS are compiled using 
> > the VS.NET 2003
> > compiler including the buffer overrun detection option.  The 1.2.x 
> > versions were compiled
> > with the VC++ 6.0 compiler which did not have buffer overrun detection.
> >
> > Hypothesis: There are buffer overruns taking place within afslogon.dll 
> > which have always
> > been there and which are only triggered in some environments.  
> > However, previously
> > they were never caught.  Now when they are caught an exception is 
> > thrown which is
> > causing winlogin.exe to halt. 
> >
> > Please install the DEBUG version of the installer from 
> > http://web.mit.edu/~jaltman/Public/OpenAFS/
> > and get me a crash log.  Hopefully this will point out the cause of 
> > the problem.
> >
> > Jeffrey Altman
> >
>