[OpenAFS] Re: Salvageserver 1.6.1-3+deb7u1 core dump

Andrew Deason adeason@sinenomine.net
Thu, 19 Jun 2014 11:12:55 -0500

On Thu, 19 Jun 2014 12:04:47 +0200 (CEST)
Harald Barth <haba@kth.se> wrote:

> On master, this looks like
> 		    opr_Verify(afs_dir_Delete(&dh, "..") == 0);
> 		    opr_Verify(afs_dir_Create(&dh, "..", &pa) == 0);
> I guess that opr_Verify is some new fancy name for Assert?
> Same patch for master as for 1.6.9 needed?

Yes, opr_Verify is supposed to mean "assert, but if asserts are turned
off still run the code".

But if you just remove the assert here, you are not fixing the problem.
All directories are supposed to have a .. entry by this point; if you
mask the problem and never investigate what's going on here, we lose all
hope of identifying and fixing the actual bug.

Andrew Deason