Aw: RE: [OpenAFS] compile fails kernel version 4.4.0-1-default

Chas Williams 3chas3@gmail.com
Tue, 08 Mar 2016 10:07:23 -0500


On Mon, 2016-03-07 at 22:37 -0500, Benjamin Kaduk wrote:
> On Mon, 7 Mar 2016, Chas Williams wrote:
> 
> > On Mon, 2016-03-07 at 01:42 -0500, Benjamin Kaduk wrote:
> > >
> > > I am given to understand that the proximal trigger is linux commit
> > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/
> > > ?id=c725bfce7968009756ed2836a8cd7ba4dc163011,
> > > which addds a path wherein -ERESTARTSYS can be returned from within
> > > VFS
> > > library code.  (Maybe there are other such paths, but we maybe just
> > > didn't
> > > notice before?)  This particular function, splice_from_pipe_next(),
> > > ends
> > > up getting called from the low-level afs_linux_storeproc() routine. 
> >
> > I haven't had time to look at this, but does this also happen with
> > the memcache?
> 
> I believe so.

Sigh.  You made me read the source code.  The memcache, because it doesn't
use files, doesn't call the linux splice routine.  It just calls afs_GenericStoreProc.
So, memcache should work just fine assuming splice is the only issue with
the 4.4 kernel.  Perhaps someone could test this.