OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_13_2-118-gb139607
Gerrit Code Review
gerrit@openafs.org
Thu, 7 Aug 2025 12:38:48 -0400
The following commit has been merged in the openafs-stable-1_8_x branch:
commit b13960792ddf931f553a1d203014b88c5ba122a8
Author: Andrew Deason <adeason@sinenomine.net>
Date: Fri Dec 30 19:04:52 2022 -0600
rx: Use add_and_fetch for rx_atomic_add_and_read
Our implementation for rx_atomic_add_and_read that uses the __sync
builtins currently uses __sync_fetch_and_add. But __sync_fetch_and_add
returns the original value, where rx_atomic_add_and_read is supposed
to return the new (added) value. Fix it to use __sync_add_and_fetch,
which rx_atomic_inc_and_read already uses.
This function has been broken in this way since it was introduced, in
commit 2758aa7171 (rx: Add the add_and_read function to our atomics),
but has never been used.
Reviewed-on: https://gerrit.openafs.org/15278
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit d051e9c62f7af40e7d673cec01070336c033b48e)
Change-Id: I9971019e7d0744f51e05515455c11449c86883f7
Reviewed-on: https://gerrit.openafs.org/16124
Reviewed-by: Ben Huntsman <ben@huntsmans.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
src/rx/rx_atomic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
OpenAFS Master Repository