[OpenAFS-devel] Patch to add much more diagnostics to vos move when run with -verbose

[Neulinger, Nathan]

Actually, since the diagnostic msg output touches about every other line
in the routine, it's kindof pointless not to reindent at the same time.
(Not re-indenting that subroutine when I did the changes would shrink
the size of the diff by maybe 10-15% at most.)=20

Yes, I'd prefer that the reindenting be done projectwide independently,
but if a patch is going to be submitted that changed so much of a
subroutine, it really is pointless to delay unless someone objects to
the different formatting.=20

-- Nathan

------------------------------------------------------------
Nathan Neulinger                       EMail:  nneul@umr.edu
University of Missouri - Rolla         Phone: (573) 341-4841
Computing Services                       Fax: (573) 341-4216


> -----Original Message-----
> From: Craig_Everhart@transarc.com=20
> [mailto:Craig_Everhart@transarc.com]=20
> Sent: Wednesday, February 06, 2002 12:37 PM
> To: openafs-bugs@openafs.org; openafs-devel@openafs.org
> Subject: Re: [OpenAFS-devel] Patch to add much more=20
> diagnostics to vos move when run with -verbose
>=20
>=20
> Actually, what worries me about the patch is how many gratuitous diffs
> it contains, presumably "cleaning up" indentation, spacing, and the
> like.  While the short-term results may look OK, it means=20
> that all kinds
> of patches down the line will keep seeing these gratuitous=20
> differences.=20
> Worse, if someone "cleans up" in some other way, still more gratuitous
> differences will abound, obfuscating real (functional) changes.
>=20
> The OpenAFS code may not be beautiful, but efforts to re-indent and so
> forth need to be coordinated a lot better than this to=20
> circumvent merge
> grief in the future.
>=20
> 		Regards,
> 		Craig
>=20
> _______________________________________________
> OpenAFS-devel mailing list
> OpenAFS-devel@openafs.org
> https://lists.openafs.org/mailman/listinfo/openafs-devel
>=20