[OpenAFS-devel] openafs-1.3.77 on SLES9 amd64_linux26 hosts... stable.

[Matthew Miller]

On Fri, Jan 14, 2005 at 12:36:30AM -0500, Derrick J Brashear wrote:
> I'd be curious to hear what problems remain with current CVS head (or wait 
> until the 6am snapshot appears on the web site if you hate using cvs)

The snapshot doesn't build for me; dies with 

./fstrace.c: In function `afs_syscall':
./fstrace.c:2140: error: `parm' undeclared (first use in this function)
./fstrace.c:2140: error: (Each undeclared identifier is reported only once
./fstrace.c:2140: error: for each function it appears in.)

And line 2140 is 

   rval = proc_afs_syscall(call, parm&code);

Which seems pretty likely to cause an error. I'm not clear exactly about the
logic in that section -- um, here's the whole bit:


    /* Linux can only handle 5 arguments in the actual syscall. */
    if (call == AFSCALL_ICL) {
    rval = proc_afs_syscall(call, parm0, parm1, parm2, eparm, &code);
    if (rval)
        code = syscall(AFS_SYSCALL, call, parm0, parm1, parm2, eparm);
    } else {
    rval = proc_afs_syscall(call, parm&code);
    if (rval)
        code = syscall(AFS_SYSCALL, call, parm0, parm1, parm2, parm3);
    }


Should line 2140 be

   rval = proc_afs_syscall(call, parm0, parm1, parm2, parm3, &code);

? (To match the "code = syscall" lines?)



-- 
Matthew Miller           mattdm@mattdm.org        <http://www.mattdm.org/>
Boston University Linux      ------>                <http://linux.bu.edu/>