[OpenAFS-devel] Mutexes in afs/LINUX/osi*

[Derrick J Brashear]

On Fri, 11 Aug 2006, Jason McCormick wrote:

> I've been trying to compile 1.5.6 to test out the new keyring PAG
> support and I've been running into some compile problems (Fedora 4,
> 2.6.17 kernel, x86_64).  One was solved (MODULE_PARM) after getting the
> latest files from HEAD that Derrick committed to to MODULE_PARM ->
> module_parm.  The second is DECLARE_MUTEX vs. DEFINE_MUTEX.  I've
> attached a patch that provides conditionals for this.
>
> However there's still a bug in the use of module_param_array on line 51
> of osi_pag_module.c.  There needs to be a 4th element to the function
> that I think should be NULL in the 3rd position, but I can't make it
> work and my Google skills are failing me.

--- LINUX/osi_pag_module.c      12 Aug 2006 16:50:37 -0000      1.3
+++ LINUX/osi_pag_module.c      13 Aug 2006 04:48:13 -0000
@@ -48,7 +48,7 @@

   static char *this_cell = 0;
   #if defined(module_param_array) && LINUX_VERSION_CODE > 
KERNEL_VERSION(2,6,9)
-module_param_array(this_cell, charp, 0);
+module_param(this_cell, charp, 0);
   #else
   MODULE_PARM(this_cell, "s");
   #endif