[OpenAFS-devel] ubik_client warnings.
Derek Atkins
warlord@MIT.EDU
Thu, 24 Aug 2006 11:26:29 -0400
Jim Rees <rees@umich.edu> writes:
[snip]
> @@ -478,6 +478,7 @@
> f_print(fout, "#ifndef SOCK_DGRAM /* XXXXX */\n");
> f_print(fout, "#include \"h/socket.h\"\n");
> f_print(fout, "#endif\n");
> + f_print(fout, "struct ubik_client;\n");
> f_print(fout, "#ifndef DTYPE_SOCKET /* XXXXX */\n");
> f_print(fout, "#ifndef AFS_LINUX22_ENV\n");
> f_print(fout, "#include \"h/file.h\"\n");
I think this patch is 100% safe, and I don't see anything wrong with
it, except for the fact that it might be "nicer" if we #included
the proper file. But I'm not a gatekeeper, so what I say means
very little.
-derek
--
Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
Member, MIT Student Information Processing Board (SIPB)
URL: http://web.mit.edu/warlord/ PP-ASEL-IA N1NWH
warlord@MIT.EDU PGP key available