[OpenAFS-devel] type errors in openafs 1.4.(1,2)

[Russ Allbery]

Steve Knodle <slk@bu.edu> writes:

> I have noticed several typing errors in openafs-1.4.1 and 1.4.2-beta
> and I would like to know what the proper method is for submitting
> patches for them for evaluation.

In general, send patches to openafs-bugs@openafs.org for them to be
evaluated for inclusion.  Unfortunately, we're also all pretty
overloaded and don't have great triage procedures.  I know I, at least,
would be glad to look more closely at a list of bugs that someone had
already checked as having a patch that's ready to apply.

However...

> While compiling in some diagnostic hooks, I noticed a fair number of
> compiler warnings, and started looking at a few.  There seem to be
> several places where variables are declared to be "pointer to pointer to
> thing" but actually used as "pointer to thing", for example:
> "des_cblock * key" in des_string_to_key
> and
> "caddr_t *" in typedef bool_t(*xdrproc_t) (void *, caddr_t *, u_int)
> in "src/rx/xdr.h"

...both of those examples are kind of annoying, since they're both
external interfaces that have been imported in a sense into AFS, and I'm
not sure what the implications of changing some of those interfaces might
be.  This is particularly true of the XDR stuff, which isn't always used
on every platform; sometimes AFS uses the system XDR libraries, I believe.

DES has had this problem for a long time.  I think that current DES
implementations may have cleaned this up, and maybe we can copy their
cleanups.

-- 
Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>