[OpenAFS-devel] type errors in openafs 1.4.(1,2)

[Jeffrey Hutzelman]

On Monday, July 03, 2006 02:02:04 PM -0700 Russ Allbery <rra@stanford.edu> 
wrote:
>> "des_cblock * key" in des_string_to_key
>
> DES has had this problem for a long time.  I think that current DES
> implementations may have cleaned this up, and maybe we can copy their
> cleanups.

If you touch des_cblock, you will probably be sad.  It's not as simple as 
it looks, because des_cblock is an array type.  Some compilers get confused 
about array types as function arguments, and generate bogus warnings for 
correct code, and no warnings for incorrect code.  The current code is 
correct; be wary of changing it.

-- Jeff