[OpenAFS-devel] Patch to prepare the client for addition protocols

Matt W. Benjamin matt@linuxbox.com
Thu, 2 Jul 2009 10:59:47 -0400 (EDT)


Hi Felix,

Good point.

Matt

----- Original Message -----
From: "Felix Frank" <Felix.Frank@Desy.de>
To: "Simon Wilkinson" <sxw@inf.ed.ac.uk>
Cc: "OpenAFS Devel" <openafs-devel@openafs.org>
Sent: Thursday, July 2, 2009 6:33:56 AM GMT -05:00 US/Canada Eastern
Subject: Re: [OpenAFS-devel] Patch to prepare the client for addition protocols

> is just untidy programming.

I can see this happening somehow, and it might even end up being quite 
readable. Still, I fear call stacks would compare like this:

Now:
CacheXProc()
	=> appropriate rx_Write/_Read

*** 

With clean seperation:
CacheXProc()
	=> fetchOp/storeOp (from generic ops structure)
		=> rx-wrapper (from struct afs_cacheOps)
			=> appropriate rx calls

That should be manageable, but adds stack overhead.

Cheers
  - Felix
_______________________________________________
OpenAFS-devel mailing list
OpenAFS-devel@openafs.org
https://lists.openafs.org/mailman/listinfo/openafs-devel