[OpenAFS-devel] Re: adding "make check" to build slaves

[Jeffrey Altman]

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigFD1CA01F6F44EC2EAB9C02D4
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 4/10/2012 1:51 AM, Andrew Deason wrote:
>> If the builders are not going to fail the build for a test failure I
>> do not see the point of running them for every build as part of
>> patchset verification.
>=20
> How else are we supposed to know if they are going to fail or not when
> we turn them on? Right now we are just guessing; they were turned on as=

> a guess and it broke all of the builders.

Its quite simple really.  You ask each of the builder owners to run make
check on their system before you turn it on.   We know that "make check"
does not work across the board.  It never has.  That is why it wasn't
turned on previously.

What should not be done is turn on a new feature that *might* break the
existing system and generate additional risk when the builders are 30 or
40 patchsets deep in builds.

In any case, what was done, was done.   I would prefer the mistakes of
the past not be repeated.



--------------enigFD1CA01F6F44EC2EAB9C02D4
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)

iQEcBAEBAgAGBQJPhCTLAAoJENxm1CNJffh49vYIAKzzoQiGGfzREBnwwKueEC0i
VSC3qvZSgIGV1bJucfiNgYNcKbdMOw6IG6wt2zbo9A6wmC1W+b2iOuEwDLOI72n9
OXbwM5nt3mW341VZU0WVd+2QoLn5o+hKr0yGPcvAIwvq6DKJ1KlslJp578IH5dKB
dAxOiA+S+5ZcbXPPWVb5KUeJTizAiH090sQF6fM1vR5U/zPiJtXPyD9lQeniGBhj
gNlHhjz8mQEJKBX6GjkLnX9KyZocug+pyi4gYRoyIGKvBMZRj4S1KU/hjTCrIqwP
XbR6QdEvdBfAjpOVgappL391T9re7VEbCYLjSppF703EVuMZjP5UCDSBvwTsmVc=
=dCfI
-----END PGP SIGNATURE-----

--------------enigFD1CA01F6F44EC2EAB9C02D4--