[OpenAFS] Re: Fwd: [OpenAFS-announce] OpenAFS 1.6.2 release candidate 3 available

Andrew Deason adeason@sinenomine.net
Fri, 18 Jan 2013 12:14:42 -0600


This is a multi-part message in MIME format.

--Multipart=_Fri__18_Jan_2013_12_14_42_-0600_3A_tM3ibQqLnkvyg
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 18 Jan 2013 12:11:47 -0500
Rich Sudlow <rich@nd.edu> wrote:

> Have any users reported success with Openafs 1.6.2 (any pre version)
> on Solaris 10 using SUNWspro (with all patches)? I'm having problems
> with the compile but suspect recent opencsw tools.

A preliminary look suggests that Oracle made the same change in a
Solaris 10 update that broke us in Solaris 11. Frank, ah, didn't mention
that...

For Rich and anyone else that may hit that and still wants to build/test
pre3 on a new Solaris 10, the error message showing that you are hitting
this issue (on 1.6.2pre3) is:

"[...]/openafs-1.6.2pre3/src/afs/SOLARIS/osi_vnodeops.c", line 1719:
prototype mismatch: 5 args passed, 6 expected

A temporary patch that should work around this is attached. A real fix
will come soon.

-- 
Andrew Deason
adeason@sinenomine.net

--Multipart=_Fri__18_Jan_2013_12_14_42_-0600_3A_tM3ibQqLnkvyg
Content-Type: text/x-diff;
 name="openafs-1.6.2pre3-vn_setpath-workaround.diff"
Content-Disposition: attachment;
 filename="openafs-1.6.2pre3-vn_setpath-workaround.diff"
Content-Transfer-Encoding: 7bit

diff --git a/src/afs/SOLARIS/osi_vnodeops.c b/src/afs/SOLARIS/osi_vnodeops.c
index f2fe46d..5240e0e 100644
--- a/src/afs/SOLARIS/osi_vnodeops.c
+++ b/src/afs/SOLARIS/osi_vnodeops.c
@@ -1716,7 +1716,7 @@ gafs_rename(struct vcache *aodp, char *aname1,
 		vp->v_path = NULL;
 	    }
 	    mutex_exit(&vp->v_lock);
-	    vn_setpath(afs_globalVp, pvp, vp, aname2, strlen(aname2));
+	    vn_setpath(afs_globalVp, pvp, vp, aname2, strlen(aname2), 0);
 # endif /* !AFS_SUN511_ENV */
 
 	    AFS_RELE(avcp);

--Multipart=_Fri__18_Jan_2013_12_14_42_-0600_3A_tM3ibQqLnkvyg--