[OpenAFS] Salvageserver 1.6.1-3+deb7u1 core dump

chas williams - CONTRACTOR chas@cmf.nrl.navy.mil
Tue, 17 Jun 2014 08:41:52 -0400


On Tue, 17 Jun 2014 10:25:21 +0200 (CEST)
Harald Barth <haba@kth.se> wrote:

> 
> http://git.openafs.org/?p=openafs.git;a=commitdiff;h=e8faeae6dcae0e566de2b21d53d3f78f3cc44e3f
> 
> > Improve JudgeEntry() detection of orphaned directories to
> > prevent unintentional deletion of their '.' and '..' entries.
> > This in turn prevents a later assert (opr_Verify) when we try to
> > delete and re-add '..' in order to attach the orphan.
> > ...
> 
> So well, now I "only" need to find something that contains that patch
> (1.6.9 I suppose) for wheezy, correct?

I don't think this patch will help at this point.  Your 1.6.1 salvager
(which doesn't have this patch) has already run and deleted the '..'
directory in what is apparently an orphaned directory.\

>Should we not just make a ".." in this situation?

That seems reasonable to me.  Failing to delete the .. in an orphaned
directory probably shouldn't be an assertion (just a warning).