[OpenAFS-win32-devel] rawops.c

Mickey Lane mickeylane33540@gmail.com
Mon, 24 Aug 2009 17:39:00 -0400


It started out that way. I picked a couple of random compile warnings to =
fix as an exercise with git. The proper fix involves changing a function =
argument type. I looked for places where the functions were called and =
couldn't find any. The two functions seem to be orphans and as they're =
the only ones in the file, I was thinking the entire file could deleted.

To answer Jeffery's question, no, they're not causing me any harm.

If the opinion is to leave them as they are, I'm OK with that.

Mickey.

> -----Original Message-----
> From: Matt W. Benjamin [mailto:matt@linuxbox.com]
> Sent: Monday, August 24, 2009 5:09 PM
> To: jaltman@secure-endpoints.com
> Cc: openafs-win32-devel@openafs.org; Mickey Lane
> Subject: Re: [OpenAFS-win32-devel] rawops.c
>=20
> I wonder if the question may have been asked in the code-cleanup
> spirit, as with many of Simon's recent (non-Windows) changes.
>=20
> Matt
>=20
> ----- "Jeffrey Altman" <jaltman@secure-endpoints.com> wrote:
>=20
> > The functions are not actively used in public sources.
> > However, you will find a lot of code in OpenAFS that is
> > not actively being used.
> >
> > Why do you want to get rid of it?
> > It is causing you any harm?
> >
> > Mickey Lane wrote:
>=20
> > > As far as I can tell, these functions are not used anywhere.
> > >
> > >
> > >
> > > Can someone confirm this?
> > >
> > >
> > >
> > > Is there any reason to keep this file?
>=20
> --
>=20
> Matt Benjamin
>=20
> The Linux Box
> 206 South Fifth Ave. Suite 150
> Ann Arbor, MI  48104
>=20
> http://linuxbox.com
>=20
> tel. 734-761-4689
> fax. 734-769-8938
> cel. 734-216-5309