[OpenAFS-devel] Bug in 1.3.85 - static declaration of freeVCList

[Zach Schimke]

--=-SZOQW5fhKnKA3O63LCxi
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Done and done. New patch.

On Tue, 2005-07-12 at 10:15, chas williams - CONTRACTOR wrote:
> In message <1121188173.16853.16.camel@playfair.mars.asu.edu>,Zach Schimke write
> s:
> >	Found a bug that stops compilation in 1.3.85. Is 'freeVCList' and
> >'Initial_freeVCList' supposed to be static declarations or not? They're
> >listed as static in src/afs/afs_vcache.c:67 but not in
> >src/afs/afs_prototypes.h:817. I'm not a programmer but something doesn't
> >mesh well here. Anyone like to double check me? 
> 
> gcc 4.0 probably.  my gcc doesnt complain about this confusion.  
> i dont believe Initial_freeVCList/freeVCList need to be anything
> but static.  remove them from afs_prototypes.h
> _______________________________________________
> OpenAFS-devel mailing list
> OpenAFS-devel@openafs.org
> https://lists.openafs.org/mailman/listinfo/openafs-devel
-- 
Zach Schimke <zschimke@mars.asu.edu>
Junior Systems Administrator
Mars Space Flight Facility

--=-SZOQW5fhKnKA3O63LCxi
Content-Disposition: attachment; filename=afs_prototypes.h.patch
Content-Type: text/x-patch; name=afs_prototypes.h.patch; charset=
Content-Transfer-Encoding: 7bit

diff -ur openafs-1.3.85/src/afs/afs_prototypes.h openafs-1.3.85-patched/src/afs/afs_prototypes.h
--- openafs-1.3.85/src/afs/afs_prototypes.h	2005-07-11 12:29:55.000000000 -0700
+++ openafs-1.3.85-patched/src/afs/afs_prototypes.h	2005-07-12 10:23:48.000000000 -0700
@@ -814,8 +814,6 @@
 extern int afsvnumbers;
 extern afs_rwlock_t afs_xvcache;
 extern afs_lock_t afs_xvcb;
-extern struct vcache *freeVCList;
-extern struct vcache *Initial_freeVCList;
 extern struct afs_q VLRU;
 extern afs_int32 vcachegen;
 extern unsigned int afs_paniconwarn;

--=-SZOQW5fhKnKA3O63LCxi--